| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: doc: Clarify OAuth validator authn_id logging |
| Date: | 2026-06-07 23:56:04 |
| Message-ID: | aiYFFH1kp_fGU9Xe@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Jun 06, 2026 at 02:36:24PM +0200, Erik Rijkers wrote:
> In doc/src/sgml/oauth-validators.sgml, and if I understand this text
> correctly (always a big if), then:
>
> "If the validator returns true and set result->authn_id then"
>
> should be:
> "If the validator returns true and sets result->authn_id then"
> (i.e., set -> sets)
>
> (added Michael in CC as he seems to collect these minimal patches, to be
> committed later as a group)
In auth-oauth.c, there is a validate() path setting the authn_id, so
your suggestion sounds right. I've grabbed that for later. My branch
can always be overwritten by somebody else's commit preference, of
course, so if you feel that this should be fixed separately, feel free
to go ahead.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-06-08 03:27:49 | pgsql: doc PG 19 relnotes: improve awkward or confusing wording |
| Previous Message | Erik Rijkers | 2026-06-06 12:36:24 | Re: pgsql: doc: Clarify OAuth validator authn_id logging |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-06-08 00:14:37 | Re: Fix comments to reference xlogrecovery.c |
| Previous Message | Tom Lane | 2026-06-07 18:57:38 | Re: Subquery pull-up increases jointree search space |