| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Subject: | Re: FOR PORTION OF gram.y target_location seems wrong |
| Date: | 2026-04-27 10:04:54 |
| Message-ID: | cd10c5b9-3690-44b2-a505-3cb833ac31cd@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.04.26 03:10, jian he wrote:
> Hi.
>
> | FOR PORTION OF ColId FROM a_expr TO a_expr
> {
> ForPortionOfClause *n = makeNode(ForPortionOfClause);
> n->range_name = $4;
> n->location = @4;
> n->target_start = $6;
> n->target_end = $8;
> n->target_location = @5;
> $$ = (Node *) n;
> }
>
> n->target_location = @5;
>
> Should be
>
> n->target_location = @6;
I think the existing code is fine. The target consists of the start and
the end value. If we pointed to @6 then one could be confused into
thinking that only the start value is meant.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-04-27 10:15:51 | Re: [Patch]: Fix excessive ProcArrayLock acquisitions with subscription max_retention_duration=0 |
| Previous Message | Bertrand Drouvot | 2026-04-27 10:01:17 | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |