Re: minor improvement in snapbuild: use existing interface and removefake code

From: ocean_li_996 <ocean_li_996(at)163(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mohen(dot)lhy(at)alibaba-inc(dot)com" <mohen(dot)lhy(at)alibaba-inc(dot)com>
Subject: Re: minor improvement in snapbuild: use existing interface and removefake code
Date: 2025-11-18 16:26:19
Message-ID: 316766f4.a513.19a97c9db73.Coremail.ocean_li_996@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi ChangAo,

Thanks for your comments.

At 2025-11-18 10:47:20, "cca5507" <cca5507(at)qq(dot)com> wrote:
> Is there a test case can reproduce the assert fail in SnapBuildGetOrBuildSnapshot()?
>
After exploring the logicalmsg_decode(),I think the Assert in SnapBuildGetOrBuildSnapshot() will not fail.
But the assert in SnapBuildGetOrBuildSnapshot() can be removed if we want to reuse it.

> We skip xact_decode() when SnapBuildCurrentState(builder) < SNAPBUILD_FULL_SNAPSHOT, but it's a bug, so your NO.3 modification might be wrong.
>
> See threads in this for details: https://commitfest.postgresql.org/patch/5029/

Wow, what a nice surprise! A few days ago, I reported a bug in [1], which I believe is the same issue you have described here.
Unfortunately, I was not able to provide a simple reproduction case at that time — but now we seem to have one :).
Regarding the fix for that issue: I will review the patch you have provided. My current idea is to update the snapshot using
builder->xmin once we reach the SNAPBUILD_CONSISTENT state. If you have any thoughts, please feel free to join the
discussion in [1].

As for the comment about this path, I can revert it currently.
Please find the updated patch attached.

[1] https://stream.boxwatch.ru/message-id/2b9e5ac8.136f.19a8f7297ee.Coremail.ocean_li_996%40163.com

Regards,
Haiyang Li

Attachment Content-Type Size
v02_minor_improvement_in_snapbuild.patch application/octet-stream 1.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-11-18 16:29:14 Re: Updating IPC::Run in CI?
Previous Message David Geier 2025-11-18 16:20:33 Re: Performance issues with parallelism and LIMIT