Re: minor improvement in snapbuild: use existing interface and removefake code

From: cca5507 <cca5507(at)qq(dot)com>
To: ocean_li_996 <ocean_li_996(at)163(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: mohen(dot)lhy(at)alibaba-inc(dot)com <mohen(dot)lhy(at)alibaba-inc(dot)com>
Subject: Re: minor improvement in snapbuild: use existing interface and removefake code
Date: 2025-11-18 02:47:20
Message-ID: tencent_1A0E34ECBA42330A6D6A83532865D4F1E609@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Some comments:

1===

Is there a test case can reproduce the assert fail in SnapBuildGetOrBuildSnapshot()?

2===

We skip xact_decode() when SnapBuildCurrentState(builder) < SNAPBUILD_FULL_SNAPSHOT, but it's a bug, so your NO.3 modification might be wrong.

See threads in this for details: https://commitfest.postgresql.org/patch/5029/

--
Regards,
ChangAo Chen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 高增琦 2025-11-18 02:54:31 Re: Compile error on the aarch64 platform: Missing asm/hwcap.h
Previous Message Corey Huinker 2025-11-18 02:34:14 Re: Extended Statistics set/restore/clear functions.