Re: The pgperltidy diffs in HEAD

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: The pgperltidy diffs in HEAD
Date: 2025-11-26 11:11:05
Message-ID: 87a5096oc6.fsf@wibble.ilmari.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:

> [2. text/x-diff; v2_perltidyversion.diff]
> diff --git a/doc/src/sgml/func/func-string.sgml b/doc/src/sgml/func/func-string.sgml
> index 7ad1436e5f8..646b5d6d8c4 100644
> --- a/doc/src/sgml/func/func-string.sgml
> +++ b/doc/src/sgml/func/func-string.sgml
> @@ -173,7 +173,7 @@

This seems unrelated to the rest of the patch patch.

> diff --git a/src/tools/pgindent/pgperltidy b/src/tools/pgindent/pgperltidy
> index 6af27d21d55..6fac758665a 100755
> --- a/src/tools/pgindent/pgperltidy
> +++ b/src/tools/pgindent/pgperltidy
> @@ -7,6 +7,12 @@ set -e
> # set this to override default perltidy program:
> PERLTIDY=${PERLTIDY:-perltidy}
>
> +PERLTIDY_VERSION=20230309
> +if ! $PERLTIDY -v | grep -q $PERLTIDY_VERSION; then
> + echo "error: pgperltidy requires perltidy v$PERLTIDY_VERSION"

I just realised, this message should really go to stderr, i.e. have >&2
on the end.

> + exit 1
> +fi
> +
> . src/tools/perlcheck/find_perl_files
>
> find_perl_files "$@" | xargs $PERLTIDY --profile=src/tools/pgindent/perltidyrc

- ilmari

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-11-26 11:16:52 Re: The pgperltidy diffs in HEAD
Previous Message Hannu Krosing 2025-11-26 11:07:04 Re: Patch: VACUUM should ignore (CREATE |RE)INDEX CONCURRENTLY for xmin horizon calculations