Re: The pgperltidy diffs in HEAD

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: The pgperltidy diffs in HEAD
Date: 2025-11-26 11:16:52
Message-ID: AEE1EF05-E028-4596-8653-0D1202BA9D3C@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 26 Nov 2025, at 12:11, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> wrote:

> This seems unrelated to the rest of the patch patch.

Yeah, I was working on a docs-patch in the same tree and only realized this
morning that I had accidentally included that part =)

>> diff --git a/src/tools/pgindent/pgperltidy b/src/tools/pgindent/pgperltidy
>> index 6af27d21d55..6fac758665a 100755
>> --- a/src/tools/pgindent/pgperltidy
>> +++ b/src/tools/pgindent/pgperltidy
>> @@ -7,6 +7,12 @@ set -e
>> # set this to override default perltidy program:
>> PERLTIDY=${PERLTIDY:-perltidy}
>>
>> +PERLTIDY_VERSION=20230309
>> +if ! $PERLTIDY -v | grep -q $PERLTIDY_VERSION; then
>> + echo "error: pgperltidy requires perltidy v$PERLTIDY_VERSION"
>
> I just realised, this message should really go to stderr, i.e. have >&2
> on the end.

Good point, I'll change that before committing and I'll also reword it to use
the same error as pgindent which has this:

"You do not appear to have $indent version $INDENT_VERSION installed on your system.\n";

Consistency is good.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2025-11-26 11:18:50 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Dagfinn Ilmari Mannsåker 2025-11-26 11:11:05 Re: The pgperltidy diffs in HEAD