Re: pg_recvlogical cannot create slots with failover=true

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_recvlogical cannot create slots with failover=true
Date: 2025-06-13 21:41:09
Message-ID: CAD21AoAqsStJBQ79YzNJoAXQhOKGTtkwijh4k+Eu9RoopoMfEQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 12, 2025 at 10:42 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 07.04.25 21:15, Masahiko Sawada wrote:
> > On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu)
> > <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >>
> >> On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote:
> >>
> >> Hi,
> >>
> >>> Thank you for updating the patch! Pushed with small cosmetic changes.
> >>
> >> Thanks for pushing the feature !
> >>
> >> I noticed one typo in the doc and here is a tiny patch to fix it.
> >>
> >> - The <option>--two-phase</option> and <option>--falover</option> options
> >> + The <option>--two-phase</option> and <option>--failover</option> options
> >
> > Thank you for the report and the patch! Pushed.
>
> I wonder if the option name --failover is ideal. To me, it sounds like
> an action "do a failover!". Also consider that pg_recvlogical has other
> action options such as --start and --create-slot, so it sounds a bit
> like those.

Fair point.

> Maybe something like --enable-failover would be better?

Sounds better, but probably the --two-phase option has the same issue?

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-06-13 21:50:27 Re: Fwd: dsm_registry: Add detach and destroy features
Previous Message Nathan Bossart 2025-06-13 21:28:27 Re: add function for creating/attaching hash table in DSM registry