Re: pg_recvlogical cannot create slots with failover=true

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_recvlogical cannot create slots with failover=true
Date: 2025-06-13 05:42:12
Message-ID: a28f66df-1354-4709-8d63-932ded4cac35@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07.04.25 21:15, Masahiko Sawada wrote:
> On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>>
>> On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote:
>>
>> Hi,
>>
>>> Thank you for updating the patch! Pushed with small cosmetic changes.
>>
>> Thanks for pushing the feature !
>>
>> I noticed one typo in the doc and here is a tiny patch to fix it.
>>
>> - The <option>--two-phase</option> and <option>--falover</option> options
>> + The <option>--two-phase</option> and <option>--failover</option> options
>
> Thank you for the report and the patch! Pushed.

I wonder if the option name --failover is ideal. To me, it sounds like
an action "do a failover!". Also consider that pg_recvlogical has other
action options such as --start and --create-slot, so it sounds a bit
like those.

Maybe something like --enable-failover would be better?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-06-13 06:29:23 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Previous Message Steven Niu 2025-06-13 05:41:10 Re: Support tid range scan in parallel?