| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Greg Burd <greg(at)burd(dot)me> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Joao Rito <joaovictor(dot)rito(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Subject: | Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |
| Date: | 2026-11-21 18:39:46 |
| Message-ID: | CAGRkXqTYMENjmfkFJUhVaX3Kk-FQnaUq+AueXhgJoCy-JddOnw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Greg,
I think v16 is pretty good.
Two small things:
1. In hash_xlog_squeeze_page(), block 0 is now registered only when
the write page is modified. So inside the BLK_NEEDS_REDO block,
mod_wbuf always ends up true. The Assert in the ntups == 0 can be change.
2. pg_waldump no longer shows the primary bucket block.
I had attached proposed fix in this email
Thanks,
Shihao
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-0001-hash-tighten-squeeze-assert-and-desc.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-11-21 19:05:30 | Re: Offline data checksum changes can cause incorrect checksum state on standbys |
| Previous Message | Cagri Biroglu | 2026-11-21 18:10:58 | Re: Per-table resync for logical replication subscriptions |