Re: Offline data checksum changes can cause incorrect checksum state on standbys

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: João Rito <joaovictor(dot)rito(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Raja Sai pranav <rajasaipranav0(at)gmail(dot)com>
Subject: Re: Offline data checksum changes can cause incorrect checksum state on standbys
Date: 2026-11-21 19:05:30
Message-ID: CAGRkXqTdaXTMzUJYn2mCE4Qs5UJPiu6VQkCOn2__N8MsrtiQPg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Raja,

Thanks for the patch, the new hint looks good to me.

One more thing. An incremental backup taken while checksums are still
being enabled online also gets refused, though the restored cluster
just comes up with checksums off. The comment in check_control_files()
says we only check when the last backup has checksums on, so I think
the test should be "== PG_DATA_CHECKSUM_VERSION" instead of "!= OFF".

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-11-21 19:19:14 Re: Use-after-free of a shared Path in add_path()/add_partial_path()
Previous Message shihao zhong 2026-11-21 18:39:46 Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE)