Re: Use an index scan in RemoveSubscriptionRel()

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Manu <manuelreyesbravo(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use an index scan in RemoveSubscriptionRel()
Date: 2026-11-20 00:25:26
Message-ID: D3C2B2CB-A7A4-4817-BE01-0A363595109F@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 20, 2026, at 03:17, Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
>
> Hi Sawada-san,
>
> On Thu, Nov 19, 2026 at 10:46 AM Masahiko Sawada
> <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> I've attached the updated patch that includes the minor fix. I'm going
>> to push it, barring any objections.
>
> Thanks, v2 looks good to me. On the test: without the reordering,
> the existing t/001_rep_changes.pl (SET PUBLICATION, line 491) and
> t/024_add_drop_pub.pl (DROP PUBLICATION, line 62) already fail with
> "btree index keys must be ordered by attribute",

Sigh! I should have run the existing tests first. I did a manual test and found the issue. To better describe the test procedure, I converted it into a TAP test, which could have been completely avoided if I had run the existing tests first.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message surya poondla 2026-11-20 00:34:30 Re: [BUG] Take a long time to reach consistent after pg_rewind
Previous Message Michael Paquier 2026-11-20 00:17:20 Re: reindexdb: Change quoting rule of --schema?