Re: reindexdb: Change quoting rule of --schema?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)kurilemu(dot)de>
Subject: Re: reindexdb: Change quoting rule of --schema?
Date: 2026-11-20 00:17:20
Message-ID: av-RkLNgtbOZdDop@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 18, 2026 at 03:38:05PM -0800, Masahiko Sawada wrote:
> On Sat, Nov 14, 2026 at 10:34 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
>> I think the change is mildly positive on balance. The rule would then be that
>> possibly-schema-qualified options like --table need interior quoting, but
>> single-name options don't. So a shell invocation would use
>> --table='"Embedded""QuoteNSP"."T"' but would use
>> --schema='Embedded"QuoteNSP'. I wouldn't back-patch it, though.
>
> +1 for the change, master only.
>
> The one downside is that passing an already-quoted name like -S
> '"Foo"' stops working, but I think that's acceptable for master.

I'd like to believe that close to nobody has the idea of using quoted
chracters in their schema names, but if they do it would burt. I'm
much more stressed about upper-case characters though, still my heart
tells me that as a HEAD-only change this is an improvement in the
long-run. Thanks for the input, both of you.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-11-20 00:25:26 Re: Use an index scan in RemoveSubscriptionRel()
Previous Message Fujii Masao 2026-11-20 00:14:18 Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed